Review main Merged

71123[BUGFIX] Fix uninitialized string offset when renaming folder

Robert Kärner CR +2 V +2 Easy +1 −1 updated 09/22/21, 20:38

Commit message

On PHP 8.0, renaming a folder in the backend might fail
with a "PHP Warning: Uninitialized string offset 0". This
is fixed by utilizing the substr() function instead.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oliver Klee +1
    • Wouter Wolters +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Wouter Wolters +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1113

  1. Robert Kärner uploaded patch set 1 09/20/21, 07:38

  2. core-ci voted on patch set 1 V +1 09/20/21, 07:54 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16926

  3. Benni Mack voted on patch set 1 CR +1 09/20/21, 14:39

  4. Wouter Wolters commented on patch set 1 V +1 CR +1 09/21/21, 20:48

  5. Christian Kuhn commented on patch set 1 CR -1 09/22/21, 07:54

    StorageRepository.php:400

    str_starts_with() ?
  6. Robert Kärner commented on patch set 1 09/22/21, 07:57

    StorageRepository.php:400 Reply

    I created this patch before we started introducing str_starts_with() in the core two days ago. I'll create a new patchset to change this.
  7. Robert Kärner uploaded patch set 2 09/22/21, 08:04

  8. Robert Kärner commented on patch set 2 09/22/21, 08:06

    StorageRepository.php:400 Reply

    Done
  9. core-ci voted on patch set 2 V +1 09/22/21, 08:19 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17019

  10. Oliver Klee voted on patch set 2 CR +1 09/22/21, 08:59

  11. Wouter Wolters voted on patch set 2 V +1 CR +1 09/22/21, 17:42

  12. Georg Ringer voted on patch set 2 V +2 CR +2 09/22/21, 20:38

  13. Georg Ringer merged patch set 3 09/22/21, 20:38