Review main Merged

71127[BUGFIX] Bump symfony/polyfill-mbstring to ^1.16

Simon Gilli CR +2 V +2 Easy +4 −3 updated 09/20/21, 15:04

Commit message

ext:frontend uses the function mb_ord which is available since
symfony/polyfill-mbstring v1.16 and to avoid issue this dependency is
properly increased and also added to ext:frontend.

Composer commands used:
* composer require "symfony/polyfill-mbstring:^1.16"
* composer require --no-update -d typo3/sysext/core "symfony/polyfill-mbstring:^1.16"
* composer require --no-update -d typo3/sysext/frontend "symfony/polyfill-mbstring:^1.16"

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 4

Review log 812

  1. Simon Gilli uploaded patch set 1 09/20/21, 13:08

  2. Simon Gilli updated the commit message in patch set 2 09/20/21, 13:11

  3. Simon Gilli updated the commit message in patch set 3 09/20/21, 13:13

  4. Simon Gilli commented on patch set 3 09/20/21, 13:17

    This change is ready for review.
    Like discussed this moring with @lolli this is the first fix of the composer dependencies.
  5. Simon Gilli wrote 09/20/21, 13:17

    Topic set to dependencies
  6. core-ci voted on patch set 1 V -1 09/20/21, 13:28 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16937

  7. core-ci voted on patch set 2 V -1 09/20/21, 13:29 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16939

  8. Simon Gilli uploaded patch set 4 09/20/21, 13:30

  9. core-ci voted on patch set 3 V -1 09/20/21, 13:42 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16940

  10. core-ci voted on patch set 4 V +1 09/20/21, 13:45 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16941

  11. Benni Mack voted on patch set 4 V +2 CR +2 09/20/21, 15:04

  12. Benni Mack merged patch set 5 09/20/21, 15:04