Review TYPO3_4-4 Merged

7113[BUGFIX] Message about missing db credentials is misleading

Markus Klein CR +2 V +2 Easy +3 −2 updated 06/03/13, 20:49

Commit message

If persistent connections are not allowed by MySQL the error message
"Can only select database if username/password/host is correctly set
first." is shown. Add an explanation that
$TYPO3_CONF_VARS['SYS']['no_pconnect'] must be set to 1, if persistent
connections are not allowed.

Review

  • Code review CR +2
    • Stefan Galinski +2
    • Stefan Neufeind +1
    • Oliver Klee +1
    • Markus Klein +1
    • Sebastian Fischer +1
  • Verified V +2
    • Stefan Galinski +2
    • Stefan Neufeind +1
    • Markus Klein +1

Files 1

Review log 6

  1. Stefan Neufeind commented on patch set 1 05/24/12, 18:32

    Verified; Looks good to me, but someone else must approve no-brainer. backport of what was already merged in 4.5+
  2. Markus Klein commented on patch set 1 05/24/12, 18:32

    Verified; Looks good to me, but someone else must approve
  3. Oliver Klee commented on patch set 1 05/24/12, 18:32

    Looks good to me, but someone else must approve
  4. Sebastian Fischer commented on patch set 1 05/24/12, 18:32

    Looks good to me, but someone else must approve
  5. Stefan Galinski commented on patch set 1 V 0 05/24/12, 18:32

    by team member; Looks good to me, approved
  6. Stefan Galinski merged patch set 1 05/24/12, 18:32