Review 10.4 Merged

71134[TASK] Explicitly define symfony polyfill packages

Benni Mack CR +2 V +2 Easy +19 −15 updated 09/21/21, 08:41

Commit message

Even though implicitly used within TYPO3 Core
through the dependency symfony/console 4.x
and others, these packages are now
defined as explicit dependencies to
help authors that they can use certain
PHP features already in TYPO3 v10 to ease
the migration.

Used composer commands:

* composer require "symfony/polyfill-php73:^1.16"
* composer require --no-update -d typo3/sysext/core "symfony/polyfill-php73:^1.16"
* composer require "symfony/polyfill-php80:^1.16"
* composer require --no-update -d typo3/sysext/core "symfony/polyfill-php80:^1.16"

Review

  • Code review CR +2 Done
    • Oliver Hader +2
  • Verified V +2 Done
    • Oliver Hader +2
    • core-ci +1 CI

Issues 1

Files 3

Review log 79

  1. Benni Mack uploaded patch set 1 09/21/21, 06:43

  2. Benni Mack uploaded patch set 2 09/21/21, 06:45

  3. Georg Ringer voted on patch set 2 V +1 CR +1 09/21/21, 06:46

  4. core-ci voted on patch set 1 V +1 09/21/21, 06:53 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16964

  5. Oliver Hader uploaded patch set 3 09/21/21, 08:28

  6. Oliver Hader voted on patch set 3 V +1 CR +1 09/21/21, 08:30

  7. core-ci voted on patch set 3 V +1 09/21/21, 08:39 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16972

  8. Oliver Hader voted on patch set 3 V +2 CR +2 09/21/21, 08:41

  9. Oliver Hader merged patch set 4 09/21/21, 08:41