Review main Merged

71164[TASK] Fluid Viewhelpers will be declared final in v12

Christian Kuhn CR +2 V +2 Easy +36 −0 updated 09/21/21, 15:50

Commit message

Communication patch for an upcoming v12 change.

We've had the situation a couple of times that core
changed Fluid Viewhelpers to adapt them to current
needs, keeping the template arguments, but changing
internal handling and method signatures.

It happened that developers then stepped up with
"This broke my own Viewhelper!" and we had to act
upon. The ImageViewHelper for instance has been a
victim of this.

From a framework point of view, Viewhelpers are
specific implementations tailored for specific use.
In most cases, they're small codewise. Extending
these classes and changing their scope should not
be supported. Developers should extend a matching
abstract instead of extending specific VH's.

The patch brings an Important.rst to pitch an
upcoming v12 change that will declare all Viewhelpers
final. The core currently of course also extends
a couple of VH's itself, but this is too
late for v11 now to change and adapt. Instead,
we'll take the time in v12 to resolve these cases
and will have a look at the abstract classes as
well to see which VH functionality should be
included in abstracts to simplify re-use and
transition for extension authors and to sharpen
core API.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 1