Review main Merged

71176[TASK] Deprecate parseFunc.sword functionality

Benni Mack CR +2 V +2 Normal +72 −2 updated 09/22/21, 17:45

Commit message

The parseFunc.sword functionality wraps HTML (usually a span tag)
around RTE-based content if:
* GET parameter ?sword[]=search-word is set
* no_cache=1 is set via GET parameter or TypoScript

This feature only works in non-cached environments due to the actual
problem that the search term should never be cached.

This happens if a result page in indexed search is clicked, which
then receives a no_cache=1 argument. This feature is highly discouraged
due to the possible server load that is created, and thus removed.

The existing solution is far from optimal and should rather be handled in
third-party extensions (such as EXT:solr does it via a HighlightViewHelper).

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 4