Review TYPO3_4-5 Merged

7121[BUGFIX] Prevent duplicate stdWrap for media content

Markus Klein CR +2 V +2 Easy +5 −6 updated 06/03/13, 20:49

Commit message

All the standard renderers handle stdWrap themselves, so the general stdWrap
handling should be moved to the customMediaRenderer block to prevent duplicate
calls to stdWrap.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Wouter Wolters +1
    • Markus Klein +1
  • Verified V +2
    • Georg Ringer +2
    • Markus Klein +1

Files 1

Review log 6

  1. Markus Klein commented on patch set 2 02/08/12, 06:39

    Verified; Looks good to me, but someone else must approve Same as 4.6.

    class.tslib_content_media.php:41

    Wrong comment here. But got into 4.6 like. Therefore keep it.
  2. Oliver Hader uploaded patch set 2 02/08/12, 06:39

  3. Oliver Hader commented on patch set 2 02/08/12, 06:39

    Automated rebasing to TYPO3_4-5 - Please consider updating your reviews V:0, R:0 as a summary of previous scores (limited to [-1;+1])
  4. Wouter Wolters commented on patch set 2 02/08/12, 06:39

    Looks good to me, but someone else must approve
  5. Georg Ringer commented on patch set 2 V 0 02/08/12, 06:39

    by team member; Looks good to me, approved
  6. Georg Ringer merged patch set 2 02/08/12, 06:39