Review main Merged

71214[BUGFIX] Push PackageManager to ExtensionManagementUtility in Bootstrap

Oli Bartsch CR +2 V +2 Easy +19 −5 updated 09/24/21, 08:36

Commit message

In order to allow conditional service registration based on
ExtensionManagementUtility::isLoaded() checks in Services.php,
the PackageManager is pushed to ExtensionManagementUtility
before container creation. This has been the case prior to #91500
in order to support runtime activated packages, but got removed
as isLoaded() checks in Services.php have never been an intended
usecase.

They have been documented in example code nonetheless
and therefore usage is now fixed:
https://docs.typo3.org/c/typo3/cms-dashboard/master/en-us/Configuration/WidgetRegistration.html#services-php-file

Documentation should be adapted to recommend conditional
services checks (ContainerBuilder::hasDefinition) instead.
Once that is done, isLoaded() in Services.php can be marked as
deprecated in future patches.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 2

Files 1