Review main Merged

71216[TASK] Migrate new record controller to Fluid-based rendering

Benni Mack CR +2 V +2 Hard +301 −327 updated 09/23/21, 15:19

Commit message

This change cleans up the NewRecordController which hasn't been
touched since ages. It cleans up the render-related functionality
into a Fluid Template.

Within Fluid, Bootstrap 5 styling is now applied properly.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 813

  1. Benni Mack uploaded patch set 1 09/23/21, 11:50

  2. core-ci voted on patch set 1 V -1 09/23/21, 12:05 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17100

  3. Benni Mack uploaded patch set 2 09/23/21, 12:11

  4. core-ci voted on patch set 2 V +1 09/23/21, 12:25 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17101

  5. Oli Bartsch uploaded patch set 3 09/23/21, 14:33

  6. Benni Mack updated the commit message in patch set 4 09/23/21, 14:35

  7. Benni Mack uploaded patch set 5 09/23/21, 14:44

  8. Oli Bartsch voted on patch set 5 V +1 CR +1 09/23/21, 14:46

  9. core-ci voted on patch set 3 V +1 09/23/21, 14:55 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17109

  10. core-ci voted on patch set 5 V +1 09/23/21, 15:02 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17111

  11. core-ci voted on patch set 4 V +1 09/23/21, 15:04 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17110

  12. Anja Leichsenring voted on patch set 5 V +2 CR +2 09/23/21, 15:19

  13. Anja Leichsenring merged patch set 6 09/23/21, 15:19