Review main Merged

71226[TASK] Avoid double-terse in incremental builds via `grunt scripts`

Benjamin Franzke CR +2 V +2 Easy +1 −5 updated 09/24/21, 09:27

Commit message

Ensure `grunt build` generates a timestamp in
Build/.cache/grunt-newer/terser/typescript/timestamp
by using `newer:terser:typescript` instead of `terser:typescript`.

This is for `grunt newer:terser:typescript`
(as executed by `grunt scripts`) to able to pick this
timestamp in subsequent builds to avoid re-tersing
files that have already been tersed in a previous full-run
(grunt build).

Background:
With the changes in #95016, `grunt terser:typescript`
became a static task that executed terser for all
typescript files in Build/JavaScript/.
Prior to that change the list of files to be
tersed was dynamically configured only for
changed files in `grunt copy:ts_files`.
Now, that means
`grunt newer:copy:ts_files terser:typescript` was equal to
`grunt newer:copy:ts_files newer:terser:typescript`.

That changed with #95015 because `grunt build` creates a cache
for incremental builds of tsc but not for newer:terser.

Note: Using newer: during `grunt build` has no impact on
which files are processed as `grunt build` cleans all cache
files upfront and therefore `newer:terser:typescript` will terse all
files in that context and only creates the timestamp additionally.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 2

Files 1