Review main Merged

71231[TASK] Deprecate page.includeCSS/includeCSSLibs.my-identifier.import

Benni Mack CR +2 V +2 Normal +62 −0 updated 09/24/21, 14:25

Commit message

The option to use the `@import` syntax for including
external CSS files through TypoScript has been deprecated.

This was possible through:

page = PAGE
page.includeCSSLibs.file1 = fileadmin/benni.css
page.includeCSSLibs.file1.import = 1

Through the "import = 1" option the output was

<style>
 @import url('fileadmin/benni.css');
</style>

instead of using the <link> tag.

Using the link tag, which is the de-facto syntax these days,
allows to load a file directly when interpreting the HTML of the
browser, instead of first interpreting the HTML, then the CSS
and have a blocking call to an external URL to continue interpreting
the CSS.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 2