Review main Merged

71233[TASK] Deprecate custom JSWindow options in HMENU settings

Benni Mack CR +2 V +2 Normal +52 −0 updated 09/24/21, 14:41

Commit message

The HMENU / TMENU options for opening up links of a menu
in a custom JavaScript popup are deprecated. Respective settings:

page.123 = HMENU
page.123.1 = TMENU
page.123.1.JSWindow = 1
page.123.1.JSWindow.params = width=200,height=300,status=0,menubar=0

alternatively this syntax was possible as well:

page.123.1 = TMENU
page.123.1.target = 200x300

both variants and properties related to JavaScript are now
deprecated.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 2