Review main Merged

71348[BUGFIX] Fix undefined array key error for protectLvar

Nikita Hovratov CR +2 V +2 Easy +1 −1 updated 09/30/21, 08:07

Commit message

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Benni Mack +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 911

  1. Nikita Hovratov uploaded patch set 1 09/29/21, 08:42

  2. core-ci voted on patch set 1 V +1 09/29/21, 09:03 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17302

  3. Tymoteusz Motylewski commented on patch set 1 09/29/21, 13:57

    AbstractMenuContentObject.php:1173

    isn't "($this->conf['protectLvar'] ?? false)" the same as "!empty($this->conf['protectLvar']) ?
  4. Nikita Hovratov commented on patch set 1 09/29/21, 14:03

    AbstractMenuContentObject.php:1173 Reply

    Yes, it is. I can change that
  5. Nikita Hovratov uploaded patch set 2 09/29/21, 14:05

  6. Nikita Hovratov commented on patch set 1 09/29/21, 14:05

    AbstractMenuContentObject.php:1173 Reply

    Done
  7. core-ci voted on patch set 2 V +1 09/29/21, 14:23 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17312

  8. Benni Mack commented on patch set 2 V +1 CR +1 09/30/21, 07:10

    AbstractMenuContentObject.php:1173 Reply

    @tymek: FWIW: ?? false is faster as it does not call a function, also empty checks for "0", "", NULL, etc. which is ugly. People tend to say one should avoid empty() if not needed.
  9. Georg Ringer voted on patch set 2 V +2 CR +2 09/30/21, 07:11

  10. Georg Ringer merged patch set 3 09/30/21, 07:11

  11. Tymoteusz Motylewski commented on patch set 3 09/30/21, 08:07

    AbstractMenuContentObject.php:1173 Reply

    I suggested empty because it preserves the behaviour, but if we can be more strict here, I'm ok with it.