Review main Abandoned

71350[TASK] Replace XML handling by GeneralUtility with XmlEncoder

Alexander Nitsche CR 0 V 0 Hard +303 −153 updated 03/24/23, 14:54

Commit message

In patch #83580 a new class XmlEncoder was introduced, which takes
care of the XML parsing in EXT:impexp. This class is used for XML
parsing throughout TYPO3 Core with this patch.

The XML handling methods of GeneralUtility

- GeneralUtility::array2xml
- GeneralUtility::xml2array
- GeneralUtility::xml2tree

should have become obsolete with this patch and marked deprecated in a
follow-up patch.

In addition, the libxml check of

- SetupCheck::checkLibXmlBug

should be checked for relevance and also marked as deprecated if it is
no longer needed. If this check is still needed, the unclean
instantiation of the XmlEncoder service with the new-operator should be
replaced with a correct service instantiation in the context of the
installation tool.

Review

  • Code review CR 0

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V 0

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 25

Show 5 more files