Review main Merged

71357Revert "[TASK] Fix undefined array key error in DataHandler logs"

Andreas Kienast CR +2 V +2 Easy +3 −1 updated 10/04/21, 20:08

Commit message

This reverts commit 84a5e8679384e276200c04f52b6ea84d7762aa67.

Reason for revert:

The proposed and merged solution of #95066 has some undetected flaws:

* array unpacking fails if the array is associative (happens with SU
  mode, see https://github.com/TYPO3/typo3/blob/master/typo3/sysext/core/Classes/Error/ErrorHandler.php#L254)
* assumes all required arguments for sprintf() are available

Since both cases cannot be solved in a clean way it's better to revert the original patch and fix only the original issue.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
    • Oliver Klee +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 810

  1. Andreas Kienast uploaded patch set 1 10/04/21, 19:28

  2. Andreas Kienast commented on patch set 1 CR -1 10/04/21, 19:28

    on it
  3. Andreas Kienast uploaded patch set 2 10/04/21, 19:31

  4. core-ci voted on patch set 1 V +1 10/04/21, 19:43 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17588

  5. core-ci voted on patch set 2 V +1 10/04/21, 19:48 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17589

  6. Andreas Kienast voted on patch set 2 V +1 CR +1 10/04/21, 19:52

  7. Oli Bartsch voted on patch set 2 V +1 CR +1 10/04/21, 20:00

  8. Oliver Klee voted on patch set 2 CR +1 10/04/21, 20:07

  9. Andreas Kienast voted on patch set 2 V +2 CR +2 10/04/21, 20:08

  10. Andreas Kienast merged patch set 3 10/04/21, 20:08