Review main Abandoned

71372[BUGFIX] Prevent page module crashing on copied page

Heinrich Pegelow CR 0 V 0 Easy +5 −1 updated 12/18/24, 21:10

Commit message

Since the uid of the default language record of "pages" is
always to be found in transOrigPointerField,
translationSource should not be considered when fetching a
localized record.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 2533

Show 68 earlier messages
  1. Heinrich Pegelow uploaded patch set 1 09/29/21, 13:05

  2. core-ci voted on patch set 1 V -1 09/29/21, 13:21 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17311

  3. Stefan Bürk uploaded patch set 2 09/29/21, 14:25

  4. core-ci voted on patch set 2 V +1 09/29/21, 14:40 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17313

  5. Robert Kärner voted on patch set 2 V +1 CR +1 09/30/21, 06:42

  6. Heinrich Pegelow uploaded patch set 3 09/30/21, 07:00

  7. Robert Kärner voted on patch set 3 V +1 CR +1 09/30/21, 07:02

  8. Stefan Bürk commented on patch set 3 09/30/21, 07:16

    I'm not sure if a test can be added for that case, as there is no failing test before change, which is green after. At least, with my little update, based on a note/finding in the forge issue existing tests are still green and not failing. I'm not into that translation things, so I'm not sure if that change is safe - or may have sideeffects. Based on current tests I would give +1, but feeling are ~~~ so I would try to invest time in there, as long as no other with deeper knowledge in that area may confirm that is okay to only use transOrigPointerField for page records.
  1. core-ci voted on patch set 3 V +1 09/30/21, 07:19 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17327

  2. Nikita Hovratov commented on patch set 3 V -1 10/01/21, 09:47

    This would cause a regression for https://forge.typo3.org/issues/84951
  3. Nikita Hovratov commented on patch set 3 V 0 10/01/21, 09:51

    Looks like it's only for non pages records.
  4. Stefan Bürk voted on patch set 3 V +1 CR +1 10/02/21, 11:49

  5. Stefan Bürk wrote 10/02/21, 13:43

    Removed Verified+1 by Stefan Bürk <stefan@buerk.tech>
  6. Anja Leichsenring rebased onto patch set 4 11/05/21, 08:04

  7. Benni Mack commented on patch set 4 11/05/21, 08:19

    I *do* think that we need tests for this, otherwise we will run in the issue as Nikita described to revert this again.
  8. core-ci voted on patch set 4 V +1 11/05/21, 08:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18925

  9. Christian Kuhn commented on patch set 4 CR -1 11/05/21, 09:52

    I think I stumbled upon scenarios in workspaces where state of l10n_source and/or parent are funny when copying records around, too. This patch here of course needs functional datahandler tests to nail the situation and to verify what the change does in details. A click-path to reproduce would help already, this could then be converted into a functional test.
  10. Benni Mack updated the commit message in patch set 5 11/18/21, 10:45

  11. core-ci voted on patch set 5 V +1 11/18/21, 11:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19462

  12. Benni Mack wrote 11/29/21, 10:15

    Change destination moved from master to main
  13. Benni Mack updated the commit message in patch set 6 11/29/21, 14:03

  14. core-ci voted on patch set 6 V +1 11/29/21, 16:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20081

  15. Stefan Bürk rebased onto patch set 7 07/08/22, 21:29

  16. Stefan Bürk commented on patch set 7 CR -1 07/08/22, 21:30

    Reply

    Reapply -1 because of this after rebase. We still need tests for it.
  17. core-ci voted on patch set 7 V +1 07/08/22, 21:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28785

  18. Benni Mack updated the commit message in patch set 8 CR -1 V +1 05/03/23, 09:19

  19. core-ci voted on patch set 8 V -1 05/03/23, 09:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41394

  20. Benni Mack updated the commit message in patch set 9 V -1 10/18/24, 14:05

  21. Benni Mack commented on patch set 9 CR -1 11/22/24, 16:30

    Unresolved

    giving another -1. I would really like to have (functional) tests for this. I "believe" I know where this comes from: When copying a page (e.g. ID 12 + its translation 13 -> l10n_source=12 and l10n_parent=12) the created page has ID 14 and its translation 15, however with l10n_source=12 AND l10n_parent=14. We need to decide whether this is the correct behavior (my gut feeling says "no", and if this is "no" we URGENTLY need an upgrade wizard, or add this to DB doctor) and then find the root cause, and fix it there.
  22. Benni Mack commented on patch set 9 12/04/24, 11:40

    Also see this issue https://forge.typo3.org/issues/97469 - I hope we can get some tests going here.
  23. Garvin Hicking commented on patch set 9 12/05/24, 09:08

    Please check out https://forge.typo3.org/issues/105765 where Dennis has spend some time as well and maybe his findings could help?
  24. Benni Mack commented on patch set 9 12/11/24, 16:44

    I suggest to use this change instead: https://review.typo3.org/c/Packages/TYPO3.CMS/+/87452
  25. Benni Mack abandoned the change 12/18/24, 21:10