Review main Merged

71382[BUGFIX] Fix the generics annotations for ObjectManager(Interface)

Oliver Klee CR +2 V +2 Normal +37 −24 updated 10/04/21, 11:39

Commit message

To avoid PHPStan warnings in projects that use ObjectManagerInterface
as a type annotation, the ObjectManager(Interface) generics need to
be on the generating methods, not on the class/interface itself.

Also streamline the PHPDoc to be more consistent, and fix the semantics
(there are no object instances, only class instances) to avoid
confusing the reader.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 2