Review main Merged

71388[BUGFIX] Replace misleading instanceof check for notification actions

Oli Bartsch CR +2 V +2 Easy +5 −5 updated 10/01/21, 10:33

Commit message

With #95406, an instance of check was added to the
Notification component, to prevent a TypeError
in case the action is not defined.
That was actually a sign of a bad usage (e.g. passing null),
and therefore the action is now made optional instead.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 2

Files 2