Review main Merged

71411[BUGFIX] Restore Drag&Drop functionality in page module

Oli Bartsch CR +2 V +2 Easy +2 −5 updated 10/02/21, 13:40

Commit message

The Drag&Drop component previously misused the
new content element wizard related “t3js” class to
check whether content can be created or not. This
had two side effects:

* Drag&Drop was never possible when new content
  element wizard was disabled
* Since #95277 Drag&Drop was completely unusable,
  because the mentioned class got removed in favor
  of a new web component

We already had the same issue with the paste button
in #95117. Therefore this is now fixed in the same way.

In the fluid based page module, the  `.t3js-page-new-ce`
class is always present, in case content creation is allowed.
Therefore it's sufficient to just check for this class. This
also makes the `else` part superfluous.

Conclusion: Drag&Drop is now always working, no matter
if new content element wizard is enabled or not, as long
as content creation is allowed for this column (e.g. no
access restricted colPos).

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 2