Review main Abandoned

71424[TASK] Re-enable php-cs-fixer "static_lambda" rule

Nikita Hovratov CR 0 V 0 Easy +4 −3 updated 11/04/21, 16:47

Commit message

This rule has been deactivated to be able to still call a closure in
FileDeclaration with the method "call". Calling a closure like this
enables to bind the "$this" context. This is indeed not necessary, as
the closure does not make any use of "$this".

There are many ways to call a closure as a class method. The most
simple one is by wrapping the property in parentheses.

This has been done now and the static_lambda rule has been added again.

Review

  • Code review CR 0

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V 0

    Imported before Forger kept the single votes, the next import adds them.

Issues 2

Files 3