Review main Merged

71426[BUGFIX] Avoid tooltip for secondary options in list modules

Oli Bartsch CR +2 V +2 Easy +11 −21 updated 10/04/21, 14:54

Commit message

The secondary options in list modules (recordlist,
filelist) are displayed in a dropdown with an icon and
the corresponding title. Therefore, an additional title
attribute is not necessary, but actually leads to a tooltip
being triggered with the same information again.

This is fixed by removing the title attribute in case the
title was already added as button tag content.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Nikita Hovratov +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Nikita Hovratov +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 911

  1. Oli Bartsch uploaded patch set 1 10/04/21, 11:37

  2. core-ci voted on patch set 1 V -1 10/04/21, 11:54 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17552

  3. Oli Bartsch uploaded patch set 2 10/04/21, 13:28

  4. Nikita Hovratov commented on patch set 2 V -1 10/04/21, 13:39

    This does also remove "aria-label". We need an additional check for this.
  5. core-ci voted on patch set 2 V +1 10/04/21, 13:43 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17558

  6. Oli Bartsch commented on patch set 2 10/04/21, 13:58

    Reply

    Why this? According to MDN: > The aria-label attribute is used to define a string that labels the current element. Use it in cases where a text label is not visible on the screen.
  7. Nikita Hovratov commented on patch set 2 V 0 10/04/21, 14:06

    Reply

    Ah, ok. My bad. In this case: do we want to remove both then?
  8. Benni Mack voted on patch set 2 V +1 CR +1 10/04/21, 14:19

  9. Nikita Hovratov voted on patch set 2 V +1 CR +1 10/04/21, 14:27

  10. Oli Bartsch voted on patch set 2 V +2 CR +2 10/04/21, 14:54

  11. Oli Bartsch merged patch set 3 10/04/21, 14:54