Review main Merged

71434[TASK] Resolve TODO in MFA activate action

Benjamin Franzke CR +2 V +2 Easy +2 −6 updated 10/05/21, 07:51

Commit message

With #95287 there was a bit of uncertainty whether a successful
return value of MfaProviderInterface::activate() indicates
"no error happened" or "provider became active".

The todo is now removed to align with the update() method
which follows "no error happened" pattern.

As update() allows providers to go inactive
with successful return value, activate() is therefore now
officially aligned to behave the same by removing the TODO.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 2

Files 2