71447[TASK] Improve links in footer of error page
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Christian Kuhn +1
- Nikita Hovratov +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1721
-
Georg Ringer uploaded patch set 1 10/05/21, 18:41
-
Georg Ringer commented on patch set 1 10/05/21, 18:42
This change is ready for review. -
Nikita Hovratov voted on patch set 1 V +1 CR +1 10/05/21, 18:47
-
core-ci voted on patch set 1 V +1 10/05/21, 19:05 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17632
-
Simon Schaufelberger voted on patch set 1 V +1 CR +1 10/05/21, 20:09
-
Benjamin Franzke uploaded patch set 2 10/06/21, 03:30
-
Benjamin Franzke commented on patch set 2 10/06/21, 03:30
Hm, I think *(semi)bold* and underline is too much emphasis on these secondary links. Either we keep the semibold font (which has a good contrast and is easy to differentiate from the normal text – but that may of course vary depending on OS font stack that is used) or only add an underline… I'm fine the with underline being a safer highlighting mechanism then font-depending semibolds. -
core-ci voted on patch set 2 V +1 10/06/21, 03:46 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17638
-
Oli Bartsch commented on patch set 2 10/06/21, 14:13
Why do we notReply
I actually would like to see the same styles as for the links in the login footer block. default: bold, no text-decoration hover: underlined -
Oli Bartsch commented on patch set 2 10/06/21, 14:14
Reply
Sorry did not check the other tab .. -
Benjamin Kott commented on patch set 2 10/06/21, 14:57
since georg asked for feedback, the decoration on copyright links were reduced in terms of visibility on purpose. i think it´s not nessesary to grab more unnessesary attention here. in general the user should be able to override the default error template, and we may should remove references here to typo3 in general / except from maybe an html comment. since benni and me were approached by the marketing team on the day before release, i opted in to keep some basic information for now and only remove "harmful" part. but i have no hard feelings for on this. -
Georg Ringer commented on patch set 3 10/07/21, 10:25
Published edit on patch set 2. -
core-ci voted on patch set 3 V +1 10/07/21, 10:41 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17727
-
Oliver Klee voted on patch set 3 CR +1 10/07/21, 11:46
-
Benjamin Franzke updated the commit message in patch set 4 10/07/21, 15:51
-
Benjamin Franzke voted on patch set 4 V +1 CR +1 10/07/21, 15:51
-
Christian Kuhn voted on patch set 4 V +1 CR +1 10/07/21, 16:03
-
core-ci voted on patch set 4 V +1 10/07/21, 16:06 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17761
-
Nikita Hovratov voted on patch set 4 CR +1 10/07/21, 17:08
-
Benjamin Franzke voted on patch set 4 V +2 CR +2 10/07/21, 19:30
-
Benjamin Franzke merged patch set 5 10/07/21, 19:30