Review main Merged

71467[BUGFIX] Properly cast possible database values

Oli Bartsch CR +2 V +2 Easy +2 −2 updated 10/06/21, 16:11

Commit message

Newly introduced UpdateValueOnFieldChange
has type hinted constructor arguments. Therefore,
we have to properly cast possible database values
before assigning them.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Nikolas Hagelstein +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Nikolas Hagelstein +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 56

  1. Oli Bartsch uploaded patch set 1 10/06/21, 15:29

  2. core-ci voted on patch set 1 V +1 10/06/21, 15:42 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17681

  3. Oliver Klee voted on patch set 1 CR +1 10/06/21, 15:50

  4. Nikolas Hagelstein voted on patch set 1 V +1 CR +1 10/06/21, 16:02

  5. Christian Kuhn voted on patch set 1 V +2 CR +2 10/06/21, 16:11

  6. Christian Kuhn merged patch set 2 10/06/21, 16:11