Review main Merged

71470[TASK] Skip one unit test dataset only for php81 until php bug is fixed

Stefan Bürk CR +2 V +2 Easy +8 −0 updated 10/06/21, 20:01

Commit message

PHP8.1.0 changed internally from gethostbyaddr() to gethostinfo() from
standard c library for the php gethostbyaddr().

On alpine docker images this leads to an issues with ::1 hostname
resolving in a unit test.

This is out of the scope to be handled by the core, thus this patch
disabled this single dataset only for 8.1, adding a todo for recheck
when the php bug is solved or otherwise mitigated.

Corresponding Issue Tracker Links:

https://github.com/docker-library/php/issues/1201
https://bugs.php.net/bug.php?id=81441

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 913

  1. Stefan Bürk uploaded patch set 1 10/06/21, 17:58

  2. Christian Kuhn commented on patch set 1 10/06/21, 18:04

    GeneralUtilityTest.php:465

    maybe add the link to the according php issue tracker?

    GeneralUtilityTest.php:468

    "Broken with php 8.1 alpine based images. Skipped for now"
  3. Stefan Bürk updated the commit message in patch set 2 10/06/21, 18:06

  4. Stefan Bürk uploaded patch set 3 10/06/21, 18:08

  5. Stefan Bürk uploaded patch set 4 10/06/21, 18:14

  6. Stefan Bürk commented on patch set 4 10/06/21, 18:15

    GeneralUtilityTest.php:465 Reply

    Done

    GeneralUtilityTest.php:468 Reply

    Done
  7. core-ci voted on patch set 1 V +1 10/06/21, 18:18 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17689

  8. Christian Kuhn voted on patch set 4 V +1 CR +1 10/06/21, 18:19

  9. core-ci voted on patch set 2 V +1 10/06/21, 18:22 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17690

  10. core-ci voted on patch set 3 V +1 10/06/21, 18:23 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17691

  11. core-ci voted on patch set 4 V +1 10/06/21, 18:37 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17692

  12. Oli Bartsch voted on patch set 4 V +2 CR +2 10/06/21, 20:01

  13. Oli Bartsch merged patch set 5 10/06/21, 20:01