Review main Merged

71473[BUGFIX] Fallback optional settings in SiteBasedTestTrait

Christian Kuhn CR +2 V +2 Easy +5 −5 updated 10/06/21, 19:59

Commit message

The functional test related SiteBasedTestTrait is used
to set up site files for testing. Some options are
optional and need to fall back to prevent warnings.
This fixes a currently suppressed PHP 8.0 warning for
functional tests.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 56

  1. Christian Kuhn uploaded patch set 1 10/06/21, 19:11

  2. core-ci voted on patch set 1 V +1 10/06/21, 19:35 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17698

  3. Stefan Bürk voted on patch set 1 CR +1 10/06/21, 19:38

  4. Stefan Bürk voted on patch set 1 V +1 10/06/21, 19:42

  5. Oli Bartsch voted on patch set 1 V +2 CR +2 10/06/21, 19:59

  6. Oli Bartsch merged patch set 2 10/06/21, 19:59