Review main Merged

71476[TASK] Quote identifier in messages with " instead of ' for ext:impexp

Stefan Bürk CR +2 V +2 Easy +18 −18 updated 10/07/21, 10:44

Commit message

Log messages generally use double-quotes.  This patch fixes the
few stragglers that do not.

This also fixes an issue in PHP 8.1, where the defaults for
htmlspecialchars() have changed resulting in some test failures.
Standardizing the quotes makes the tests pass in all cases.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • crell +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1115

  1. Stefan Bürk uploaded patch set 1 10/06/21, 21:00

  2. Stefan Bürk updated the commit message in patch set 2 10/06/21, 21:02

  3. Stefan Bürk voted on patch set 2 CR -1 10/06/21, 21:05

  4. core-ci voted on patch set 1 V +1 10/06/21, 21:23 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17702

  5. core-ci voted on patch set 2 V +1 10/06/21, 21:28 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17703

  6. Stefan Bürk uploaded patch set 3 10/06/21, 21:54

  7. core-ci voted on patch set 3 V +1 10/06/21, 22:08 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17705

  8. crell commented on patch set 3 10/07/21, 08:14

    RenderPreviewImportPageAndRecords.php:185

    Stray trailing whitespace (and elsewhere in this file).

    RenderPreviewImportPageAndRecordsByUpdateWithDiff.php:36

    Stray trailing whitespace (and elsewhere in this file).

    RenderPreviewImportPageAndRecordsWithDiff.php:34

    Stray trailing whitespace (and elsewhere in this file).
  9. Stefan Bürk commented on patch set 3 10/07/21, 08:18

    RenderPreviewImportPageAndRecords.php:185 Reply

    That was before. And needs, as otherwise the test(s) would fail. Not related to this change at all. Why gerrit shows it on both diff sides I do not know.

    RenderPreviewImportPageAndRecordsByUpdateWithDiff.php:36 Reply

    That was before. And needs, as otherwise the test(s) would fail. Not related to this change at all. Why gerrit shows it on both diff sides I do not know.

    RenderPreviewImportPageAndRecordsWithDiff.php:34 Reply

    That was before. And needs, as otherwise the test(s) would fail. Not related to this change at all. Why gerrit shows it on both diff sides I do not know.
  10. crell updated the commit message in patch set 4 10/07/21, 08:19

  11. crell commented on patch set 4 CR +1 10/07/21, 08:24

    RenderPreviewImportPageAndRecords.php:185 Reply

    Ack

    RenderPreviewImportPageAndRecordsByUpdateWithDiff.php:36 Reply

    Ack

    RenderPreviewImportPageAndRecordsWithDiff.php:34 Reply

    Ack
  12. core-ci voted on patch set 4 V +1 10/07/21, 08:35 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17719

  13. Christian Kuhn voted on patch set 4 V +1 CR +1 10/07/21, 10:43

  14. Oli Bartsch voted on patch set 4 V +2 CR +2 10/07/21, 10:44

  15. Oli Bartsch merged patch set 5 10/07/21, 10:44