71476[TASK] Quote identifier in messages with " instead of ' for ext:impexp
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- crell +1
- Christian Kuhn +1
-
Verified V +2 Done
- Oli Bartsch +2
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 4
- typo3/sysext/impexp/Classes/ImportExport.php+8 −8
- typo3/sysext/impexp/Tests/Functional/Fixtures/ArrayAssertions/RenderPreviewImportPageAndRecords.php3+4 −4
- typo3/sysext/impexp/Tests/Functional/Fixtures/ArrayAssertions/RenderPreviewImportPageAndRecordsByUpdateWithDiff.php3+3 −3
- typo3/sysext/impexp/Tests/Functional/Fixtures/ArrayAssertions/RenderPreviewImportPageAndRecordsWithDiff.php3+3 −3
Review log 1115
-
Stefan Bürk uploaded patch set 1 10/06/21, 21:00
-
Stefan Bürk updated the commit message in patch set 2 10/06/21, 21:02
-
Stefan Bürk voted on patch set 2 CR -1 10/06/21, 21:05
-
core-ci voted on patch set 1 V +1 10/06/21, 21:23 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17702
-
core-ci voted on patch set 2 V +1 10/06/21, 21:28 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17703
-
Stefan Bürk uploaded patch set 3 10/06/21, 21:54
-
core-ci voted on patch set 3 V +1 10/06/21, 22:08 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17705
-
crell commented on patch set 3 10/07/21, 08:14
RenderPreviewImportPageAndRecordsByUpdateWithDiff.php:36Stray trailing whitespace (and elsewhere in this file).RenderPreviewImportPageAndRecordsWithDiff.php:34Stray trailing whitespace (and elsewhere in this file). -
Stefan Bürk commented on patch set 3 10/07/21, 08:18
RenderPreviewImportPageAndRecords.php:185ReplyThat was before. And needs, as otherwise the test(s) would fail. Not related to this change at all. Why gerrit shows it on both diff sides I do not know.RenderPreviewImportPageAndRecordsByUpdateWithDiff.php:36ReplyThat was before. And needs, as otherwise the test(s) would fail. Not related to this change at all. Why gerrit shows it on both diff sides I do not know.RenderPreviewImportPageAndRecordsWithDiff.php:34ReplyThat was before. And needs, as otherwise the test(s) would fail. Not related to this change at all. Why gerrit shows it on both diff sides I do not know. -
crell updated the commit message in patch set 4 10/07/21, 08:19
-
crell commented on patch set 4 CR +1 10/07/21, 08:24
RenderPreviewImportPageAndRecords.php:185ReplyAckRenderPreviewImportPageAndRecordsByUpdateWithDiff.php:36ReplyAckRenderPreviewImportPageAndRecordsWithDiff.php:34ReplyAck -
core-ci voted on patch set 4 V +1 10/07/21, 08:35 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17719
-
Christian Kuhn voted on patch set 4 V +1 CR +1 10/07/21, 10:43
-
Oli Bartsch voted on patch set 4 V +2 CR +2 10/07/21, 10:44
-
Oli Bartsch merged patch set 5 10/07/21, 10:44
RenderPreviewImportPageAndRecords.php:185