Review main Merged

71491[BUGFIX] Extbase UriBuilder warning in Backend context

Christian Kuhn CR +2 V +2 Easy +1 −1 updated 10/07/21, 19:39

Commit message

The extbase UriBuilder can be used in backend context,
ActionMenuItemViewHelper does that for instance. The
code accesses $GLOBALS['TSFE'] at one point, which
may not be set.

The ActionMenuItemViewHelperTest triggers this, but
it should be a general asset of UriBuilder to work
without TSFE, so this is not considered an incomplete
test setup, but fixed in UriBuilder directly.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 1