Review main Merged

71504[BUGFIX] Enforce setCopyMode in clipboard

Jochen Roth CR +2 V +2 Easy +10 −12 updated 10/19/21, 13:24

Commit message

The clipboard component features helper methods,
which generate a URL to update the clipboard
state with new elements. Those are used in
recordlist and filelist.

Previously the "setCopyMode" parameter was
only set in case the element should be "copied".
This then might lead to no "mode" set in the
clipboardData at all. Like other modules
already do, the helper methods do now always
set the "setCopyMode" parameter to enforce
the generation of the "mode" key in the
clipboardData.

Anyways, an access of the "mode" in the page
module is secured by a null collapse operator.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 2