Review main Merged

71507[BUGFIX] Add correct value for $itemsCriteriaField

Jochen Roth CR +2 V +2 Easy +1 −1 updated 10/09/21, 07:32

Commit message

Adding a file collection to the file links
content element leads to undefined array
key warning.

This is fixed by setting the itemsCriteriaField
name to "files".

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oli Bartsch +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Oli Bartsch +1
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 810

  1. Jochen Roth uploaded patch set 1 10/08/21, 10:13

  2. core-ci voted on patch set 1 V +1 10/08/21, 10:26 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17809

  3. Nikita Hovratov voted on patch set 1 V +1 CR +1 10/08/21, 10:41

  4. Oli Bartsch commented on patch set 1 V -1 10/08/21, 11:19

    IMO the bug isn't this call but the fact that $itemsCriteriaField contains a wrong value. To solve this https://github.com/TYPO3/typo3/blob/master/typo3/sysext/core/Classes/Resource/Collection/StaticFileCollection.php#L35 must be set to "files" instead of "items".
  5. Jochen Roth uploaded patch set 2 10/08/21, 11:48

  6. Nikita Hovratov commented on patch set 2 V +1 CR +1 10/08/21, 11:57

    Interesting, so it was always wrong since the beginning.
  7. core-ci voted on patch set 2 V +1 10/08/21, 12:10 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17813

  8. Oli Bartsch voted on patch set 2 V +1 CR +1 10/08/21, 13:13

  9. Georg Ringer voted on patch set 2 V +2 CR +2 10/09/21, 07:32

  10. Georg Ringer merged patch set 3 10/09/21, 07:32