Review main Merged

71512[BUGFIX] Move virtual storage 0 back to public path

Simon Gilli CR +2 V +2 Normal +120 −18 updated 10/12/21, 14:32

Commit message

It was a conceptual mistake to move storage 0 base path
outside the document root (public path), because this complete
compatibility layer relies on the fact that this storage
is public. Moving it outside the public path, implicitly
made this storage private, with all logical consequences like
eID public URLs. This of course isn't desired and a breaking
change of behaviour.

With moving the base path back it means, that trying to access this
BC layer with paths that are not within the public path,
will not work any more. This is fine though, because this
never worked before TYPO3 11.5 anyway.

The reason why this was made working was EXT:form, which
used the storage 0 compat layer for resolving form
definitions from extensions, which did not work, when
installing extensions into vendor folder (instead of the still
current default, where extensions are installed in public folder).

Accessing public resources from vendor installed extensions
will still work with this change, because the public asset
URL will automatically be calculated, but accessing private resources
will thrown an exception to clarify that the storage 0 compat layer
is not made to make this possible.

Also fix form framework to not rely on FAL compatibility
layer during form loading.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 4