Review main Merged

71515[BUGFIX] Align default value of displayThumbs

Oli Bartsch CR +2 V +2 Easy +1 −1 updated 10/09/21, 07:16

Commit message

The "displayThumbs" module setting is
fetched two times in the FileBrowser. One
time to determine whether thumbnails
should be displayed and a second time
to set the current value of the display
thumbnails "toggle".

However, the default values of those two
cases differed, which then led to a default
state where the "toggle" was active, while
no thumbnails were displayed.

This is now fixed by using the same default
for both cases.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 711

  1. Oli Bartsch uploaded patch set 1 10/08/21, 22:45

  2. Oli Bartsch updated the commit message in patch set 2 10/08/21, 22:47

  3. Oli Bartsch updated the commit message in patch set 3 10/08/21, 22:54

  4. Nikita Hovratov updated the commit message in patch set 4 10/08/21, 23:03

  5. core-ci voted on patch set 2 V +1 10/08/21, 23:07 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17850

  6. Nikita Hovratov voted on patch set 4 V +1 CR +1 10/08/21, 23:08

  7. core-ci voted on patch set 1 V +1 10/08/21, 23:08 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17848

  8. core-ci voted on patch set 4 V +1 10/08/21, 23:17 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17852

  9. core-ci voted on patch set 3 V +1 10/08/21, 23:18 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17851

  10. Georg Ringer voted on patch set 4 V +2 CR +2 10/09/21, 07:16

  11. Georg Ringer merged patch set 5 10/09/21, 07:16