Review main Merged

71521[BUGFIX] Fix undefined index and offset warning in lowlevel QueryGenerator

Stefan Bürk CR +2 V +2 Easy +4 −4 updated 10/10/21, 11:52

Commit message

This patch fixes undefined index/offset warnings in ext:lowlevel
QueryGenerator using null coalescing operator.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Georg Ringer +1
    • Oliver Klee +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Georg Ringer +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 79

  1. Stefan Bürk uploaded patch set 1 10/09/21, 15:46

  2. Stefan Bürk uploaded patch set 2 10/09/21, 16:03

  3. core-ci voted on patch set 1 V +1 10/09/21, 16:07 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17875

  4. core-ci voted on patch set 2 V +1 10/09/21, 16:18 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17876

  5. Oliver Klee voted on patch set 2 CR +1 10/09/21, 16:43

  6. Georg Ringer voted on patch set 2 V +1 CR +1 10/10/21, 06:32

  7. Oli Bartsch commented on patch set 2 V +2 CR +2 10/10/21, 10:44

    QueryGenerator.php:2571

    Just FYI, usually we use "false" here.
  8. Oli Bartsch merged patch set 3 10/10/21, 10:44

  9. Stefan Bürk commented on patch set 3 10/10/21, 11:52

    QueryGenerator.php:2571 Reply

    Thx, Will remember that.