Review main Merged

71523[BUGFIX] (Re)initalize beuser based LanguageService after beuser

Stefan Bürk CR +2 V +2 Easy +1 −2 updated 10/11/21, 10:43

Commit message

BrokenLinkRepositoryTest of ext:linkvalidator initalizes
beuser dynamicly for tests and testdatasets. LanguageService
has been initializied once as setup, before a valid beuser
was initialized. Thus undefined index BE_USER warnings has
been created.

This patch (re)initializes the LanguageService using the
corresponsign Bootstrap::initializeLanguageObject() method
after each backend user initializing, and remove the single
to early call from setUp().

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Oliver Klee +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 56

  1. Stefan Bürk uploaded patch set 1 10/09/21, 18:48

  2. core-ci voted on patch set 1 V +1 10/09/21, 19:09 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17879

  3. Oli Bartsch voted on patch set 1 V +1 CR +1 10/10/21, 10:46

  4. Oliver Klee voted on patch set 1 CR +1 10/10/21, 11:50

  5. Christian Kuhn voted on patch set 1 V +2 CR +2 10/11/21, 10:43

  6. Christian Kuhn merged patch set 2 10/11/21, 10:43