Review main Abandoned

71525[TASK] Replace file and folder actions with enumerations

Nikita Hovratov CR 0 V 0 Hard +374 −130 updated 11/04/21, 17:13

Commit message

There are tons of magic strings of file and folder
actions for FAL. In order to reduce the amount of
them, two new enumerations have been added:
FileAction and FolderAction. These two enumerations
hold all possible actions for their type
respectively.

Some part of the code could be extracted into the
methods "isReadAction" and "isWriteAction".

With this, passing invalid action names is now
deprecated.

In addition an interface has been added for File
and Folder to ensure polymorphic calls of the
checkActionPermission method.

Review

  • Code review CR 0

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V 0

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 26

Show 6 more files