Review main Merged

71531[BUGFIX] PHP 8.0 warnings in QueryGenerator

Christian Kuhn CR +2 V +2 Easy +19 −20 updated 10/11/21, 15:36

Commit message

Yet another series of PHP 8 stabilizations for
ext:lowlevel QueryGenerator. This time found by
functional tests when error handling in functionals
is turned off.

* Various null coalescence within class itself

* A test setup change which string_replace()'ed
  within a serialized string, which invalidates
  length specifications. Fixed by serializing
  after replace operations, instead of before.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 2