Review main Merged

71554[BUGFIX] Properly encode JSON when forwarding to RequireJS

Oliver Hader CR +2 V +2 Normal +88 −2 updated 10/21/21, 18:07

Commit message

When forwarding configuration as JSON encoded data when loading
RequireJS modules in form engine, escape sequences need to be
handled explicitly. It is not possible to break the serialization
by injection techniques, however client-side parsing might fail.

The problem has been discovered, when PHP class names
(e.g. `\Vendor\Package\Name`) lead to JSON parsing errors
(e.g. `JSON.parse('"\\Vendor\\Package\\Name"');`).

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 3