Review main Merged

71616[BUGFIX] Fix undefined array key warnings in GraphicalFunctions

Nikita Hovratov CR +2 V +2 Easy +21 −21 updated 11/22/23, 21:47

Commit message

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Jochen Roth +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1517

  1. Nikita Hovratov uploaded patch set 1 10/13/21, 10:08

  2. Christian Kuhn voted on patch set 1 V +1 CR +1 10/13/21, 10:09

  3. Benjamin Franzke commented on patch set 1 10/13/21, 10:16

    GraphicalFunctions.php:601

    Why is $conf['angle'] in the else-block 25 lines down not adapted?
  4. Nikita Hovratov commented on patch set 1 10/13/21, 10:20

    GraphicalFunctions.php:601 Reply

    Not catched by a test I guess. I can try to check the else branch by setting this "niceText" parameter.
  5. core-ci voted on patch set 1 V +1 10/13/21, 10:25 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18021

  6. Nikita Hovratov uploaded patch set 2 10/13/21, 10:26

  7. Nikita Hovratov commented on patch set 2 10/13/21, 10:27

    GraphicalFunctions.php:601 Reply

    Done
  8. Christian Kuhn voted on patch set 2 V +1 CR +1 10/13/21, 10:38

  9. core-ci voted on patch set 2 V +1 10/13/21, 10:54 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18024

  10. Oliver Klee voted on patch set 2 CR +1 10/13/21, 11:07

  11. Jochen Roth voted on patch set 2 V +1 CR +1 10/13/21, 12:29

  12. Christian Kuhn voted on patch set 2 V +2 CR +2 10/13/21, 12:29

  13. Christian Kuhn merged patch set 3 10/13/21, 12:29

  14. Simon Schaufelberger commented on patch set 3 10/13/21, 16:06

    GraphicalFunctions.php:478

    Should the default value not be "1,1"? I wanted to write a test for this case already to verify that. The docs don't mention a default value sadly.

    GraphicalFunctions.php:2061 Unresolved

    I would prefer the default value of "0,0" here like the docs say: https://docs.typo3.org/m/typo3/reference-typoscript/master/en-us/Gifbuilder/ObjectNames/Index.html#image instead of an empty string
  15. Nikita Hovratov commented on patch set 3 10/13/21, 17:22

    GraphicalFunctions.php:478 Reply

    Yes, you are right with both. Do you wanna fix it?
  16. Simon Schaufelberger commented on patch set 3 10/14/21, 15:24

    GraphicalFunctions.php:478 Reply

    yes, I will also provide a test case
  17. Nikita Hovratov commented on patch set 3 11/22/23, 21:47

    GraphicalFunctions.php:478 Reply

    Done