Review main Merged

71617[BUGFIX] Avoid fallback to ObjectManager in PropertyMapperTest

Christian Kuhn CR +2 V +2 Easy +6 −0 updated 10/13/21, 12:35

Commit message

The on-the-fly type converters need to be registered
in container to avoid deprecated ObjectManager fallbacks.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 56

  1. Christian Kuhn uploaded patch set 1 10/13/21, 10:16

  2. core-ci voted on patch set 1 V +1 10/13/21, 10:30 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18022

  3. Benni Mack commented on patch set 1 V +1 CR +1 10/13/21, 12:09

    clever solution!
  4. Jochen Roth voted on patch set 1 V +1 CR +1 10/13/21, 12:34

  5. Christian Kuhn voted on patch set 1 V +2 CR +2 10/13/21, 12:35

  6. Christian Kuhn merged patch set 2 10/13/21, 12:35