Review main Merged

71622[BUGFIX] Avoid warnings in ShortcutRepository

Christian Kuhn CR +2 V +2 Easy +2 −2 updated 10/13/21, 12:41

Commit message

Some details in (deprecated) ShortcutRepository should
be sanitized to avoid warnings.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Jochen Roth +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Jochen Roth +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 89

  1. Christian Kuhn uploaded patch set 1 10/13/21, 11:31

  2. Oli Bartsch voted on patch set 1 V +1 CR +1 10/13/21, 11:39

  3. core-ci voted on patch set 1 V +1 10/13/21, 11:45 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18030

  4. Simon Schaufelberger commented on patch set 1 10/13/21, 11:48

    ShortcutRepository.php:205

    what is a usecase when a record doesn't have a pid?
  5. Christian Kuhn commented on patch set 1 10/13/21, 12:30

    ShortcutRepository.php:205 Reply

    Unsure. And frankly, I don't care *that* much, since this hole section is deprecated and will be removed in v12.
  6. Jochen Roth voted on patch set 1 V +1 CR +1 10/13/21, 12:31

  7. Christian Kuhn voted on patch set 1 V +2 CR +2 10/13/21, 12:32

  8. Christian Kuhn merged patch set 2 10/13/21, 12:32

  9. Simon Schaufelberger commented on patch set 2 10/13/21, 12:41

    ShortcutRepository.php:205 Reply

    Done