Review main Merged

71629[BUGFIX] Incomplete setup in AuthenticationServiceTest

Christian Kuhn CR +2 V +2 Easy +1 −0 updated 10/13/21, 18:53

Commit message

AuthenticationService relies on 'userid_column' being
set. The functional test setup is incomplete and
adapted with the patch.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Jochen Roth +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 67

  1. Christian Kuhn uploaded patch set 1 10/13/21, 15:45

  2. core-ci voted on patch set 1 V +1 10/13/21, 16:00 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18058

  3. Oliver Klee voted on patch set 1 CR +1 10/13/21, 16:56

  4. Stefan Bürk voted on patch set 1 V +1 CR +1 10/13/21, 17:29

  5. Jochen Roth voted on patch set 1 V +1 CR +1 10/13/21, 17:33

  6. Christian Kuhn voted on patch set 1 V +2 CR +2 10/13/21, 18:53

  7. Christian Kuhn merged patch set 2 10/13/21, 18:53