Review main Merged

71630[BUGFIX] Add missing field_name to CategoryCollection test setup

Christian Kuhn CR +2 V +2 Easy +1 −0 updated 10/13/21, 19:08

Commit message

CategoryCollectionTest needs to set up 'field_name' for
a collection record to satisfy CategoryCollection::create()
needs.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Benjamin Franzke +1
    • Wouter Wolters +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Benjamin Franzke +1
    • Wouter Wolters +1
    • Stefan Bürk +1

Issues 1

Files 1

Review log 911

  1. Christian Kuhn uploaded patch set 1 10/13/21, 16:13

  2. core-ci voted on patch set 1 V +1 10/13/21, 16:28 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18060

  3. Stefan Bürk voted on patch set 1 V +1 CR +1 10/13/21, 17:17

  4. Jochen Roth voted on patch set 1 V +1 CR +1 10/13/21, 18:05

  5. Benjamin Franzke updated the commit message in patch set 2 10/13/21, 18:46

  6. Benjamin Franzke voted on patch set 2 V +1 CR +1 10/13/21, 18:46

  7. Wouter Wolters voted on patch set 2 V +1 CR +1 10/13/21, 18:47

  8. Stefan Bürk voted on patch set 2 V +1 CR +1 10/13/21, 18:47

  9. Christian Kuhn voted on patch set 2 V +2 CR +2 10/13/21, 19:05

  10. Christian Kuhn merged patch set 3 10/13/21, 19:05

  11. core-ci voted on patch set 2 V +1 10/13/21, 19:08 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18071