Review main Merged

71633[TASK] Explicitly setup errorHandler in ErrorHandlerTest

Christian Kuhn CR +2 V +2 Easy +6 −0 updated 10/13/21, 18:46

Commit message

The testing framework will soon disable error suppression
by unsetting the default errorHandler for functional tests.

The ErrorHandlerTest then needs to explicitly enable the
core errorHandler to test it. The patch adds according
configuration for this test.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Jochen Roth +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Jochen Roth +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 56

  1. Christian Kuhn uploaded patch set 1 10/13/21, 17:53

  2. core-ci voted on patch set 1 V +1 10/13/21, 18:12 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18066

  3. Jochen Roth voted on patch set 1 V +1 CR +1 10/13/21, 18:38

  4. Benjamin Franzke voted on patch set 1 V +2 CR +2 10/13/21, 18:43

  5. Benjamin Franzke merged patch set 2 10/13/21, 18:43

  6. Stefan Bürk voted on patch set 2 V +1 CR +1 10/13/21, 18:46