Review main Merged

71634[BUGFIX] Avoid warning in LanguageService

Christian Kuhn CR +2 V +2 Easy +1 −1 updated 10/13/21, 19:04

Commit message

LanguageService->sL('LLL:') leads to a warning. Even
though this is of course a broken call, the code should
sanitize this case.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • Wouter Wolters +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • Wouter Wolters +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 67

  1. Christian Kuhn uploaded patch set 1 10/13/21, 17:58

  2. core-ci voted on patch set 1 V +1 10/13/21, 18:13 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18067

  3. Jochen Roth voted on patch set 1 V +1 CR +1 10/13/21, 18:40

  4. Stefan Bürk voted on patch set 1 V +1 CR +1 10/13/21, 18:45

  5. Wouter Wolters voted on patch set 1 V +1 CR +1 10/13/21, 18:46

  6. Christian Kuhn voted on patch set 1 V +2 CR +2 10/13/21, 19:04

  7. Christian Kuhn merged patch set 2 10/13/21, 19:04