Review main Merged

71640[BUGFIX] Consider table name on retrieving extension key

Oli Bartsch CR +2 V +2 Easy +22 −11 updated 10/20/21, 13:19

Commit message

The NewRecordController previously relied on a record
title being a locallang reference. This was used to
determine the extension key, to further fetch the
corresponding extension title and the icon.

This then lead to various misbehaviour for records,
not using a locallang reference as title. For example,
the last record title might end up being used as the
group title, and similar.

To prevent such scenarios an additional check is
added, which tries to fetch the extension key from
the table name, which might most probably work
since by convention a table name starting with
tx_ or tt_ is followed by the extension name.

Another topic, not part of this patch is the fact
that the extension title is fetched from the
ext_emconf.php file. This file however might
no longer exist in the future. Therefore, the
corresponding part needs to be refactored
to also take the composer.json into account.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 1317

  1. Oli Bartsch uploaded patch set 1 10/13/21, 22:35

  2. Oli Bartsch uploaded patch set 2 10/13/21, 22:46

  3. core-ci voted on patch set 1 V +1 10/13/21, 22:52 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18079

  4. core-ci voted on patch set 2 V +1 10/13/21, 23:02 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18080

  5. Christian Kuhn commented on patch set 2 10/14/21, 08:14

    i don't understand this sentence. 'hardly relied on' ?
  6. Oli Bartsch updated the commit message in patch set 3 10/14/21, 08:23

  7. Oli Bartsch commented on patch set 3 10/14/21, 08:24

    Reply

    removed "hardly"
  8. core-ci voted on patch set 3 V +1 10/14/21, 08:43 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18088

  9. Jochen Roth voted on patch set 3 V +1 CR +1 10/15/21, 09:09

  10. Christian Kuhn updated the commit message in patch set 4 10/19/21, 14:57

  11. Jochen Roth voted on patch set 4 V +1 CR +1 10/19/21, 14:59

  12. Christian Kuhn voted on patch set 4 V +1 CR +1 10/19/21, 15:00

  13. core-ci voted on patch set 4 V +1 10/19/21, 15:10 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18322

  14. Christian Kuhn voted on patch set 4 V +2 CR +2 10/19/21, 15:17

  15. Christian Kuhn merged patch set 5 10/19/21, 15:17

  16. Simon Schaufelberger commented on patch set 5 10/20/21, 02:04

    NewRecordController.php:485 Unresolved

    str_starts_with should have been used here
  17. Oliver Hader commented on patch set 5 10/20/21, 13:19

    NewRecordController.php:485 Unresolved