Review main Merged

71772[BUGFIX] Avoid incomplete setup in StorageRepositoryTest

Christian Kuhn CR +2 V +2 Easy +13 −3 updated 10/14/21, 17:32

Commit message

The StorageRepositoryTest tests createLocalStorage() which
calls testCaseSensitivity() to find out if a local filesystem
is case sensitive. It creates a test file to do so, but does
not check if the directory itself exists.

This should probably handled in createLocalStorage(), but
for now we create the directories in the test to fix
a raised warning and add a @todo to test and code.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 911

  1. Christian Kuhn uploaded patch set 1 10/14/21, 14:46

  2. core-ci voted on patch set 1 V +1 10/14/21, 15:05 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18107

  3. Jochen Roth voted on patch set 1 V +1 CR +1 10/14/21, 15:11

  4. Stefan Bürk commented on patch set 1 10/14/21, 15:53

    StorageRepositoryTest.php:143

    That's generally kind of dirty - not for this patch but also in generall. As the public path is the test instance path. That means this outside folder is created one folder above the instance path. And as such not cleared for new test runs, thus creating cross test (instance) interfearing. What do you think Christian ?
  5. Christian Kuhn commented on patch set 1 10/14/21, 16:04

    StorageRepositoryTest.php:143 Reply

    right. unsure if we should fix that now, though ... add a todo in place, maybe?
  6. Stefan Bürk commented on patch set 1 10/14/21, 16:06

    StorageRepositoryTest.php:143 Reply Unresolved

    Ack. Thought about, but no quick and clean solution for it. Let's add the todo.
  7. Stefan Bürk uploaded patch set 2 10/14/21, 17:08

  8. Stefan Bürk voted on patch set 2 V +1 CR +1 10/14/21, 17:08

  9. core-ci voted on patch set 2 V +1 10/14/21, 17:31 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18113

  10. Anja Leichsenring voted on patch set 2 V +2 CR +2 10/14/21, 17:31

  11. Anja Leichsenring merged patch set 3 10/14/21, 17:32