Review main Merged

71775[BUGFIX] Consider language in redirects:checkintegrity

Sybille Peters CR +2 V +2 Hard +195 −66 updated 10/21/21, 10:26

Commit message

The ext:redirects integrity check was implemented
without considering site language host and prefix for
the integrity check, thus reporting false positive
redirect conflicts.

This patch collects page uris, respecting the site
language configuration for the page language. This way,
the same slugs for multiple languages are not detected
as conflicting anymore. Furthermore tests are extended
to verify that the same slugs within several language
variants of one page are covered correctly.

Example for false positive redirect conflict:

- pages.slug=/test
- pages.sys_language_uid=1
- url: https://example.com/de/test

Now, assuming no other page of the same language has
the slug /test and a redirect has a source_path=/test,
there should be no match.

Several @todo were added which need deeper research
and are out of the scope of this patch.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 5