Review main Merged

71797[BUGFIX] Do not log page access failures

Markus Klein CR +2 V +2 Easy +3 −7 updated 10/15/21, 19:29

Commit message

It does not make sense to log page access failures
to the logging framework. Pages are inaccessible
for a reason, no need to log every try.
(404 responses are logged by the webserver)

This helps with monitoring and removes useless
log messages from the logs.

Also avoid to respond with an internal server error to
page-requests that are hidden by (inherited) rootline
constraints. These are normalized to 404. These cases
should be improved to differentiate between 404 (hidden
due to rootline) and 403 (access denied due to rootline)
in future.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 1