Review main Merged

71832[TASK] Have a FunctionalDeprecated test suite

Christian Kuhn CR +2 V +2 Expert +1147 −181 updated 10/15/21, 18:56

Commit message

With functional tests now failing on warnings and notices
and *showing* deprecations, the next step is to make sure
the functional test suite does not trigger deprecated
code anymore. The strategy is similar to "UnitDeprecated":
All functional tests that actively test deprecated code
are moved to a dedicated test suite that *does not* fail
on deprecations, while the main functional test suite
*does* fail on deprecations.

This helps to ensure core code does not call deprecated
functionality.

The patch:
* Adds a FunctionalDeprecated test suite as new home
  for tests that test deprecated subjects like the
  deprecated extbase ObjectManager.
* Moves and splits existing tests to FunctionalDeprecated,
  including fixtures as needed.
* Adds the test suite to runTests.sh and adapts the
  docker setup accordingly.
* Adds FunctionalDeprecated suite to gitlab-ci pre-merge
  and nightly in various php / dbms combinations.
* Enables convertDeprecationsToExceptions="true" for
  the main functional test suite and "false" for the
  new FunctionalDeprecated suite.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 2

Files 23

Show 3 more files