Review main Merged

71836[BUGFIX] Avoid php8.1 fatal error in FileSessionHandler

Stefan Bürk CR +2 V +2 Easy +6 −0 updated 10/16/21, 09:02

Commit message

PHP8.1 added return types for some internal php
functions, class methods and interfaces, like it
has been added in php8.0 for internal function
arguments. Generally this leads to deprecation
messages.

Classes extending internal classes or implementing
php interfaces, must implement compatible return
types. As a workaround for older php version which
do not support return types, an attribute can be
added to suppress this message until return types
can be adjusted.

The patch adds the according '#[ReturnTypeWillChange]'
attribute to add PHP 8.1 compatibility and keep 7.4.

This patch fixes a fatal php 8.1 error found by
functional tests.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 1